Skip to content

chore(orion): tune buck2 and scorpio config #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamin-747 merged 1 commit into from
Mar 13, 2026
+11 −4
Merged

chore(orion): tune buck2 and scorpio config #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion orion/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ utoipa.workspace = true
common = { path = "../common" }
ring = "0.17.14"
hex = { workspace = true }
scorpiofs = "0.1.1"
scorpiofs = "0.2.0"
tokio-util = { workspace = true }
3 changes: 3 additions & 0 deletions orion/buck/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ impl Buck2 {

pub fn command(&self) -> Command {
let mut command = Command::new(&self.program);
command
.env("BUCKD_STARTUP_TIMEOUT", "30")
.env("BUCKD_STARTUP_INIT_TIMEOUT", "1200");
match &self.isolation_dir {
None => {}
Some(isolation_dir) => {
Expand Down
4 changes: 2 additions & 2 deletions orion/runner-config/scorpio.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ git_email = "admin@mega.org"

# Dicfuse 读取配置
dicfuse_readable = "true"
load_dir_depth = "3"
fetch_file_thread = "10"
load_dir_depth = "5"
fetch_file_thread = "20"
dicfuse_import_concurrency = "4"
dicfuse_dir_sync_ttl_secs = "5"
dicfuse_reply_ttl_secs = "2"
Expand Down
6 changes: 5 additions & 1 deletion orion/src/buck_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,8 @@ fn get_repo_targets(file_name: &str, repo_path: &Path) -> anyhow::Result<Targets
tracing::debug!("Get targets for repo {repo_path:?} (attempt {attempt}/{MAX_ATTEMPTS})");
let mut command = std::process::Command::new("buck2");
command
.env("BUCKD_STARTUP_TIMEOUT", "30")
.env("BUCKD_STARTUP_INIT_TIMEOUT", "1200")
.args(targets_arguments())
.args(["--isolation-dir", &isolation_dir]);
command.current_dir(repo_path);
Expand Down Expand Up @@ -748,7 +750,9 @@ pub async fn build(
let mut cmd = Command::new("buck2");
// --event-log and --build-report are used to collect build execution status
// at target level (e.g. pending / running / succeeded / failed).
cmd.args([
cmd.env("BUCKD_STARTUP_TIMEOUT", "30")
.env("BUCKD_STARTUP_INIT_TIMEOUT", "120")

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use consistent buckd init timeout in build command

The build path now sets BUCKD_STARTUP_INIT_TIMEOUT to 120, while the other buck2 entry points in this same change use 1200; in slow I/O environments where buckd initialization takes longer than 2 minutes but less than 20 minutes, build will still fail with startup timeouts even though target discovery succeeds. This inconsistency in build undermines the stated timeout hardening and can cause task builds to fail intermittently under load.

Useful? React with 👍 / 👎.

.args([
"--isolation-dir", &isolation_dir,
"--event-log", EVENT_LOG_FILE,
]);
Expand Down
Loading