Skip to content

Conversation

@PauwelsPieter
Copy link

@PauwelsPieter PauwelsPieter commented Dec 16, 2025

Why: Inconsistent use of uppercasing when parsing the link headers in documentation.

Closes: /

What's being changed (if available, include any code snippets, screenshots, or gifs):

image Link to the specific [section in the docs](https://docs.github.com/en/rest/using-the-rest-api/using-pagination-in-the-rest-api?apiVersion=2022-11-28#example-creating-a-pagination-method).

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copilot AI review requested due to automatic review settings December 16, 2025 14:18
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 16, 2025
@github-actions
Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
rest/using-the-rest-api/using-pagination-in-the-rest-api.md fpt
ghec
ghes@ 3.19 3.18 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.19 3.18 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inconsistency in the keyset pagination example code where the regex pattern for parsing HTTP Link headers was using uppercase "Next" instead of the correct lowercase "next". According to RFC 8288 (Web Linking), relation types in Link headers are case-insensitive but conventionally lowercase. The fix ensures the regex pattern at line 130 now matches the lowercase "next" already used in the string check at line 148, making the example code consistent and following the standard convention.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant