C#: Remove some unbounded TC computations#21348
Draft
hvitved wants to merge 4 commits intogithub:mainfrom
Draft
Conversation
6ccee8f to
be9a579
Compare
3f36bbd to
3d93e01
Compare
8c9fb8c to
acd6f41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are in some cases computing (more or less) full non-fast TCs, which can be very expensive in cases like this one.
For example, the charpred of
AstNodeinControlFlowGraphImpl.qllwould previously result in the following DIL:That is, we would compute a full TC only to afterwards filter away the target column via the
any#expr#.