JS: Fix FPs with js/incorrect-suffix-check#18547
Merged
erik-krogh merged 5 commits intogithub:mainfrom Jan 22, 2025
Merged
Conversation
…sed later to find matching `indexOf` calls)
…in `getAnEquivalentIndexOfCall()`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Looks reasonable. Brief change note please, mentioning the validation pattern that is now recognised?
adityasharad
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue (see backref).
Evaluations were uneventful. I did a rerun of the
nightly-olddue to the first one hinting slightly towards a performance regression, but that disappeared on a rerun.