C++: Silence alerts coming from CMake test compilation files#18408
Merged
jketema merged 4 commits intogithub:mainfrom Jan 9, 2025
Merged
C++: Silence alerts coming from CMake test compilation files#18408jketema merged 4 commits intogithub:mainfrom
jketema merged 4 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
config-silence
branch
from
adf824a to
2472f76
Compare
jketema
force-pushed
the
config-silence
branch
from
2472f76 to
6d0d6b2
Compare
jketema
force-pushed
the
config-silence
branch
from
6d0d6b2 to
b6f412b
Compare
geoffw0
reviewed
Jan 9, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Couple of tiny points, otherwise LGTM.
| parent.getParentContainer().getBaseName() = "CMakeFiles" | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to worry about files in subdirectories of the TryCompile-* directory? i.e. CMakeFiles/CMAkeScratch/TryCompile-foo/bar?
Contributor
Author
There was a problem hiding this comment.
No. My understanding is that CMake creates each directory on-the-fly and only uses it for one test compilation.
...Likely Typos/ExprHasNoEffect/CMakeFiles/CMakeScratch/TryCompile-abcdef/CheckFunctionExists.c
Outdated
Show resolved
Hide resolved
…ct/CMakeFiles/CMakeScratch/TryCompile-abcdef/CheckFunctionExists.c Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com>
geoffw0
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This silences alert wobble, as the suffix of CMake
TryCompile-directories is random and changes each time a project is built.There's probably other queries where this makes sense, but for now I've limited myself to queries for which I concretely observed
TryCompile-files showing up.DCA nightly shows that the neovim alerts on
TryCompile-files disappears, and similarly for DCA autobuild posix and .NET diagnostics.Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).