Java: Make java/weak-cryptographic-algorithm give a reason why the algo is insecure#18161
Merged
owen-mc merged 8 commits intogithub:mainfrom Jan 13, 2025
Merged
Conversation
owen-mc
changed the title
owen-mc
changed the title
java/weak-cryptographic-algorithm give a reason why the algo is insecure
This changes the order of the algorithms in the regex, but I don't think that makes any difference.
owen-mc
force-pushed
the
java/weak-crypto-algo-more-informative
branch
from
399bcd6 to
95d26d9
Compare
smowton
previously approved these changes
Dec 4, 2024
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Slight suggested tweak, otherwise LGTM
Co-authored-by: Chris Smowton <smowton@github.com>
owen-mc
dismissed stale reviews from egregius313 and joefarebrother
via
5959a73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do:
Make an internal companion PR to update the language test that is failing.Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).Changes are validated at scale (internal access required).Adding a new query? Consider also adding the query to autofix.