Skip to content

Conversation

@mlinksva
Copy link
Contributor

Fixes #1138

Copilot AI review requested due to automatic review settings December 14, 2025 05:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the clipboard.js external library dependency and replaces it with a vanilla JavaScript implementation, addressing issue #1138. The change reduces dependencies and uses modern browser APIs for clipboard functionality.

Key Changes:

  • Implemented native clipboard functionality using navigator.clipboard.writeText() with fallback to document.execCommand('copy')
  • Replaced clipboard.js event-based architecture with direct event listeners for click, mouseleave, and blur events
  • Removed all clipboard.js vendor files and updated build configuration accordingly

Reviewed changes

Copilot reviewed 4 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
assets/js/app.js Replaced clipboard.js with vanilla JavaScript implementation using modern Clipboard API and execCommand fallback
_includes/footer.html Removed clipboard.min.js script tag
bower.json Removed clipboard dependency from bower configuration
_config.yml Removed clipboard test directory from exclusions
.gitignore Removed clipboard vendor directory exclusions
assets/vendor/clipboard/* Deleted all clipboard.js vendor files (dist, documentation, configuration)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mlinksva mlinksva merged commit 6599de4 into gh-pages Dec 14, 2025
5 checks passed
@mlinksva mlinksva deleted the clipclipboard branch December 14, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is clipboard.js still needed?

2 participants