Skip to content

[tooling] Add pre-commit hooks using LeftHook #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jovnc wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

[tooling] Add pre-commit hooks using LeftHook #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lefthook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
pre-commit:
parallel: true
commands:
ruff-lint:
glob: "*.py"
run: ruff check --fix {staged_files}
stage_fixed: true

ruff-format:
glob: "*.py"
run: ruff format {staged_files}
stage_fixed: true
Comment on lines +2 to +12
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running ruff-lint and ruff-format in parallel can cause race conditions since both commands may try to modify the same files simultaneously. The format command should run after lint completes to ensure consistent results. Consider setting parallel: false or using the piped: true option to run commands sequentially, or move ruff-format to a separate sequential group.

Copilot uses AI. Check for mistakes.

mypy:
glob: "*.py"
run: mypy {staged_files}
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running mypy on individual staged files may miss type errors related to imports and cross-module dependencies. The CI workflow runs mypy . to type-check the entire codebase. Consider changing this to run mypy . instead of mypy {staged_files} to maintain consistency with CI and catch all type errors. Alternatively, if you want to keep it file-specific for performance, you may want to add a flag like --follow-imports=silent to avoid false positives.

Suggested change
run: mypy {staged_files}
run: mypy .

Copilot uses AI. Check for mistakes.
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ pytest
repo-smith

# Developer tooling dependencies
lefthook
ruff
mypy
PyGithub
Expand Down
4 changes: 4 additions & 0 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ fi
source venv/bin/activate

pip install -r requirements.txt -U --no-cache-dir

if ! command -v lefthook &>/dev/null; then
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is inverted. The condition checks if the command does NOT exist (! command -v lefthook), but then attempts to run lefthook install. This will fail because lefthook won't be available. The installation should happen after pip installs the requirements (which includes lefthook), so the condition should check if lefthook DOES exist. Change the condition to if command -v lefthook &>/dev/null; then or remove the negation operator.

Suggested change
if ! command -v lefthook &>/dev/null; then
if command -v lefthook &>/dev/null; then

Copilot uses AI. Check for mistakes.
lefthook install
fi