[remote-branch-rename] Improve verify logic and update tests#260
[remote-branch-rename] Improve verify logic and update tests#260jovnc merged 4 commits intogit-mastery:mainfrom
Conversation
|
Hi @jovnc, thank you for your contribution! 🎉 This PR comes from your fork Before you request for a review, please ensure that you have tested your changes locally! Important The previously recommended way of using Please read the following instructions for the latest instructions. PrerequisitesEnsure that you have the Testing stepsIf you already have a local Git-Mastery root to test, you can skip the following step. Create a Git-Mastery root locally: gitmastery setupNavigate into the Git-Mastery root (defaults to cd gitmastery-exercises/Edit the {
# other fields...
"exercises_source": {
"username": "jovnc",
"repository": "exercises",
"branch": "fix/remote-branch-rename"
}
}Then, you can use the gitmastery download <your new change>
gitmastery verifyChecklist
Important To any reviewers of this pull request, please use the same instructions above to test the changes. |
There was a problem hiding this comment.
Pull request overview
Updates the remote_branch_rename exercise grader and its unit tests to focus on verifying a local+remote branch rename workflow (renaming improve-loadding to improve-loading) and to use an actual temporary remote repo in tests instead of mocking.
Changes:
- Removed the previous
try-quick-fix -> fix-scrolling-bugsetup and verification logic. - Updated
verify.pyto check for the renamed local branch and validate remote branch presence/absence via fetch + remote refs. - Refactored tests to use
include_remote_repo=Trueand perform real push/delete operations against the temp remote.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| remote_branch_rename/verify.py | Removes the old branch-rename checks and verifies local+remote rename for improve-loadding. |
| remote_branch_rename/test_verify.py | Replaces mocking with a real temporary remote repo and updates scenarios accordingly. |
| remote_branch_rename/download.py | Updates exercise repo setup to only create/push improve-loadding (removes try-quick-fix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@VikramGoyal23 @jiaxinnns @desmondwong1215 @SAN-MUYUN Ready for review, thanks! |
|
LGTM! Tested and it works as expected. |
Exercise Review
Exercise Discussion
Fixes #27
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?git-autograder?app?