Change checkout reference from 'stable' to 'dev'#28
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI workflow to run against the dev branch of the upstream gismo/gismo repository instead of stable, affecting what code version the CI builds/tests against.
Changes:
- Switch
actions/checkoutforgismo/gismofromref: stabletoref: dev. - No functional change to the
ctestinvocation (diff hunk is line-number-only).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -26,7 +26,7 @@ jobs: | |||
| - uses: actions/checkout@master | |||
There was a problem hiding this comment.
actions/checkout@master is a moving ref; pin this to a major version tag (e.g., actions/checkout@v4) or a specific commit SHA to avoid supply-chain risk and unexpected CI behavior when master changes.
| ref: dev | ||
| path: ./gismo | ||
|
|
||
| - uses: actions/checkout@master |
There was a problem hiding this comment.
This second checkout also uses actions/checkout@master. Consider pinning to actions/checkout@v4 (or a commit SHA) for reproducibility and to reduce the risk of CI breaking due to upstream changes.
| with: | ||
| repository: gismo/gismo | ||
| ref: stable | ||
| ref: dev |
There was a problem hiding this comment.
Checking out gismo/gismo by branch name (ref: dev) makes CI non-deterministic over time (the workflow result can change without any changes in this repo). If the goal is to test against a specific state, consider pinning to a tag or commit SHA (or documenting why tracking dev is required).
| ref: dev | |
| ref: 0123456789abcdef0123456789abcdef01234567 # pinned commit (was: dev) |
No description provided.