Fix/show data labels#1
Draft
yoshiokatsuneo wants to merge 10 commits into
Draft
Conversation
This fixes the following exception:
```
UnboundLocalError: local variable 'value_is_number' referenced before assignment
File "rq/worker.py", line 1431, in perform_job
rv = job.perform()
File "rq/job.py", line 1280, in perform
self._result = self._execute()
File "rq/job.py", line 1317, in _execute
result = self.func(*self.args, **self.kwargs)
File "redash/tasks/alerts.py", line 36, in check_alerts_for_query
new_state = alert.evaluate()
File "redash/models/__init__.py", line 1002, in evaluate
new_state = next_state(op, value, threshold)
File "redash/models/__init__.py", line 928, in next_state
elif not value_is_number and op not in [OPERATORS.get("!="), OPERATORS.get("=="), OPERATORS.get("equals")]:
```
…eSQL JSON getredash#7339 (2nd try) (getredash#7348) * Sanitize NaN, Infinite, -Infinite causing error when saving as PostgreSQL JSON getredash#7339 (2nd try) * Move json nsanitaize to on the top of json_dumps * Fix comment
Co-authored-by: snickerjp <snickerjp@gmail.com>
…h#7359) * Upgrade plotly.js to version 2 * Fix styling error reported by styled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
After updated to plotly.js to version 2.0, "show data labels" on bar chart does not works as "textposition" default was changed on plotly.js 2.0.
This PR fixes the issue by setting "textposition" explicitly to "null" or "auto"(plotly.js default).
How is this tested?
I confirmed that data label is shown only when "show data labels" is checked.