feat(feedback): Add autoCorrect and spellCheck config to FeedbackWidget#5627
Open
sbs44 wants to merge 2 commits intogetsentry:mainfrom
Open
feat(feedback): Add autoCorrect and spellCheck config to FeedbackWidget#5627sbs44 wants to merge 2 commits intogetsentry:mainfrom
sbs44 wants to merge 2 commits intogetsentry:mainfrom
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
sbs44
force-pushed
the
feat/feedback-widget-autocorrect-spellcheck
branch
from
9ba1207 to
23ca722
Compare
sbs44
force-pushed
the
feat/feedback-widget-autocorrect-spellcheck
branch
from
23ca722 to
9ae2419
Compare
Collaborator
|
Thank you for the contribution! I have a few suggestions on the email/username input, other than that, it's looking good! |
Collaborator
|
@sentry review |
- Add optional autoCorrect and spellCheck props to FeedbackGeneralConfiguration - Pass props through to all three TextInput elements (default: true) - Add autoCapitalize="none" to email input to prevent iOS capitalization - Add tests for prop forwarding, defaults, and email autoCapitalize
sbs44
force-pushed
the
feat/feedback-widget-autocorrect-spellcheck
branch
from
9ae2419 to
c8cfaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add optional
autoCorrectandspellCheckprops toFeedbackGeneralConfiguration, forwarded to allTextInputelements in the feedback form. Both default totrue(matching React Native defaults) so this is non-breaking.Also adds
autoCapitalize="none"to the email input — email addresses shouldn't be auto-capitalized.💡 Motivation and Context
Fixes #5626 — feedback forms used for bug reports often contain technical terms, stack traces, and identifiers that trigger aggressive auto-correct behavior. Consumers should be able to opt out.
💚 How did you test it?
autoCorrect={false}andspellCheck={false}forwarded to all three TextInputstruewhen not specifiedautoCapitalize="none"📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
None.