Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 083f560+dirty | 358.21 ms | 382.00 ms | 23.79 ms |
| 8a4ce6f | 422.88 ms | 408.33 ms | -14.55 ms |
| 8db9631+dirty | 442.78 ms | 461.96 ms | 19.18 ms |
| 955f2eb+dirty | 422.74 ms | 410.19 ms | -12.55 ms |
| 818a608 | 495.84 ms | 498.08 ms | 2.25 ms |
| ba75c7c | 367.72 ms | 369.16 ms | 1.44 ms |
| d9f44bb+dirty | 400.64 ms | 431.65 ms | 31.01 ms |
| df83aad+dirty | 420.87 ms | 434.98 ms | 14.11 ms |
| 11ded16+dirty | 317.29 ms | 329.15 ms | 11.86 ms |
| 526494a+dirty | 422.80 ms | 438.90 ms | 16.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 083f560+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 8a4ce6f | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 8db9631+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 955f2eb+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 818a608 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| ba75c7c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| d9f44bb+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
| df83aad+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 11ded16+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 526494a+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c1573b3+dirty | 355.65 ms | 448.82 ms | 93.17 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| 1e7a472+dirty | 319.58 ms | 372.29 ms | 52.71 ms |
| d9f44bb+dirty | 460.61 ms | 496.62 ms | 36.00 ms |
| df83aad+dirty | 493.94 ms | 521.76 ms | 27.82 ms |
| 526494a+dirty | 361.10 ms | 410.84 ms | 49.74 ms |
| 3bd3f0d+dirty | 334.38 ms | 402.19 ms | 67.81 ms |
| b80b14f+dirty | 320.33 ms | 376.06 ms | 55.73 ms |
| 5691430+dirty | 376.70 ms | 401.58 ms | 24.88 ms |
| f234eb4+dirty | 313.23 ms | 333.31 ms | 20.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c1573b3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 1e7a472+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| d9f44bb+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
| df83aad+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 526494a+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 3bd3f0d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| b80b14f+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 5691430+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| f234eb4+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1220.18 ms | 1223.18 ms | 3.00 ms |
| 083f560+dirty | 1227.33 ms | 1242.02 ms | 14.69 ms |
| 6479fd5+dirty | 1228.48 ms | 1231.32 ms | 2.84 ms |
| 8ff81c0+dirty | 1209.17 ms | 1206.15 ms | -3.02 ms |
| df83aad+dirty | 1187.20 ms | 1190.55 ms | 3.36 ms |
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 3bd3f0d+dirty | 1231.51 ms | 1229.10 ms | -2.41 ms |
| 6fee48d+dirty | 1222.14 ms | 1231.44 ms | 9.30 ms |
| 9a81842+dirty | 1225.82 ms | 1220.77 ms | -5.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 083f560+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 6479fd5+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 8ff81c0+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| df83aad+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3bd3f0d+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 6fee48d+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 9a81842+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
antonis
left a comment
There was a problem hiding this comment.
Blocked on the addition of 0.83.1 in https://github.com/react-native-community/rn-diff-purge
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1213.79 ms | 1210.45 ms | -3.34 ms |
| 083f560+dirty | 1215.27 ms | 1231.96 ms | 16.69 ms |
| 6479fd5+dirty | 1207.80 ms | 1215.12 ms | 7.32 ms |
| 8ff81c0+dirty | 1219.51 ms | 1221.66 ms | 2.15 ms |
| df83aad+dirty | 1202.06 ms | 1203.83 ms | 1.77 ms |
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
| ba75c7c+dirty | 1236.14 ms | 1240.69 ms | 4.55 ms |
| 3bd3f0d+dirty | 1230.18 ms | 1243.41 ms | 13.22 ms |
| 6fee48d+dirty | 1208.85 ms | 1218.52 ms | 9.67 ms |
| 9a81842+dirty | 1210.98 ms | 1211.40 ms | 0.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 083f560+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 6479fd5+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 8ff81c0+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| df83aad+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ba75c7c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3bd3f0d+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 6fee48d+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 9a81842+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
|
We don't have any guidelines regarding that but in general I don't think that bumping RN version for e2e tests is that needed for every minor version, it's just too much hassle with not so many benifits. Maybe we should do it only for major versions? |
antonis
left a comment
There was a problem hiding this comment.
0.84.0-rc.0 and will keep this in draft till the final release
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
📢 Type of change
📜 Description
Bump E2E tests to 0.84.-RC
💡 Motivation and Context
https://github.com/facebook/react-native/releases/tag/v0.84.0-rc.5
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog