Skip to content

[skill-drift] update(sentry-elixir-sdk): add capture_* config options for v13.2.0#256

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
skill-drift/sentry-elixir-sdk-skill-drift-update-sentry-elixir-sdk-add-1783346751
Open

[skill-drift] update(sentry-elixir-sdk): add capture_* config options for v13.2.0#256
github-actions[bot] wants to merge 1 commit into
mainfrom
skill-drift/sentry-elixir-sdk-skill-drift-update-sentry-elixir-sdk-add-1783346751

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Auto-generated from external SDK content. Review all links and code suggestions before acting on them.

Summary

Updates Elixir SDK skill to document new unified config pattern introduced in PR #1077 (v13.2.0).

Changes

  1. Document new capture_* config options (v13.2.0+):

    • capture_log_messages — report Logger messages as error events
    • capture_level — minimum level for error events
    • capture_metadata — metadata keys for error events
    • capture_excluded_domains — domains to exclude from error events

    These options allow enable_logs: true to handle both structured logs AND error event capture, eliminating the need to manually configure LoggerHandler for most use cases.

  2. Fix incorrect default: Corrected excluded_domains default — only :cowboy is excluded by default (not :bandit). The :bandit exclusion was reverted in PR #1099.

Files Modified

  • skills/sentry-elixir-sdk/references/logging.md — added unified config section with new options table
  • skills/sentry-elixir-sdk/SKILL.md — fixed bandit exclusion statement in troubleshooting

SDK versions: v13.2.0+ for capture_* options; v12.0.0+ for enable_logs

Source PRs

… for v13.2.0

Automated drift-fix run.

Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
@github-actions github-actions Bot requested a review from a team as a code owner July 6, 2026 14:05
Comment on lines +200 to +205
| `:excluded_domains` | `[atom]` | `[]` | Domains to exclude from structured logs |
| **Error Events (Issues)** | | | |
| `:capture_log_messages` | `boolean` | `false` | When `true`, Logger messages (e.g., `Logger.error("oops")`) are also reported as error events. Crashes are always reported regardless of this setting. Since v13.2.0 |
| `:capture_level` | `Logger.level` | `:error` | Minimum level for error events (including crashes). Since v13.2.0 |
| `:capture_metadata` | `[atom] \| :all` | `[]` | Logger metadata keys to include in error events (added under `:extra` as `logger_metadata`). Since v13.2.0 |
| `:capture_excluded_domains` | `[atom]` | `[]` | Domains to exclude from error events. Since v13.2.0 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Documentation for enable_logs: true is near pre-existing text that incorrectly implies excluded_domains defaults to [:cowboy], which is no longer true for this new configuration.
Severity: MEDIUM

Suggested Fix

Update the pre-existing "Best Practices" and "Troubleshooting" sections (lines 249 and 259) to clarify that the [:cowboy] default only applies to the older LoggerHandler configuration, not the new enable_logs: true method. Alternatively, remove the outdated claims about the default.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: skills/sentry-elixir-sdk/references/logging.md#L200-L205

Potential issue: The new documentation recommends using `enable_logs: true` for log
configuration. While the new configuration table correctly states that
`excluded_domains` defaults to `[]` in this mode, it is placed directly above
pre-existing "Best Practices" and "Troubleshooting" sections. These older sections claim
the default for `excluded_domains` is `[:cowboy]`. This creates a misleading context
where users adopting the new `enable_logs: true` feature will likely believe Cowboy
domains are excluded by default and will not configure `excluded_domains: [:cowboy]`
themselves, resulting in duplicate Cowboy crash events being sent to Sentry.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants