[skill-drift] update(sentry-elixir-sdk): add capture_* config options for v13.2.0#256
Open
github-actions[bot] wants to merge 1 commit into
Conversation
… for v13.2.0 Automated drift-fix run. Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
Comment on lines
+200
to
+205
| | `:excluded_domains` | `[atom]` | `[]` | Domains to exclude from structured logs | | ||
| | **Error Events (Issues)** | | | | | ||
| | `:capture_log_messages` | `boolean` | `false` | When `true`, Logger messages (e.g., `Logger.error("oops")`) are also reported as error events. Crashes are always reported regardless of this setting. Since v13.2.0 | | ||
| | `:capture_level` | `Logger.level` | `:error` | Minimum level for error events (including crashes). Since v13.2.0 | | ||
| | `:capture_metadata` | `[atom] \| :all` | `[]` | Logger metadata keys to include in error events (added under `:extra` as `logger_metadata`). Since v13.2.0 | | ||
| | `:capture_excluded_domains` | `[atom]` | `[]` | Domains to exclude from error events. Since v13.2.0 | |
There was a problem hiding this comment.
Bug: Documentation for enable_logs: true is near pre-existing text that incorrectly implies excluded_domains defaults to [:cowboy], which is no longer true for this new configuration.
Severity: MEDIUM
Suggested Fix
Update the pre-existing "Best Practices" and "Troubleshooting" sections (lines 249 and 259) to clarify that the [:cowboy] default only applies to the older LoggerHandler configuration, not the new enable_logs: true method. Alternatively, remove the outdated claims about the default.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-elixir-sdk/references/logging.md#L200-L205
Potential issue: The new documentation recommends using `enable_logs: true` for log
configuration. While the new configuration table correctly states that
`excluded_domains` defaults to `[]` in this mode, it is placed directly above
pre-existing "Best Practices" and "Troubleshooting" sections. These older sections claim
the default for `excluded_domains` is `[:cowboy]`. This creates a misleading context
where users adopting the new `enable_logs: true` feature will likely believe Cowboy
domains are excluded by default and will not configure `excluded_domains: [:cowboy]`
themselves, resulting in duplicate Cowboy crash events being sent to Sentry.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
Summary
Updates Elixir SDK skill to document new unified config pattern introduced in PR #1077 (v13.2.0).
Changes
Document new
capture_*config options (v13.2.0+):capture_log_messages— report Logger messages as error eventscapture_level— minimum level for error eventscapture_metadata— metadata keys for error eventscapture_excluded_domains— domains to exclude from error eventsThese options allow
enable_logs: trueto handle both structured logs AND error event capture, eliminating the need to manually configureLoggerHandlerfor most use cases.Fix incorrect default: Corrected
excluded_domainsdefault — only:cowboyis excluded by default (not:bandit). The:banditexclusion was reverted in PR #1099.Files Modified
skills/sentry-elixir-sdk/references/logging.md— added unified config section with new options tableskills/sentry-elixir-sdk/SKILL.md— fixed bandit exclusion statement in troubleshootingSDK versions: v13.2.0+ for capture_* options; v12.0.0+ for enable_logs
Source PRs
capture_*config