fix: Add all attachments when CaptureFeedback#5077
Open
bitsandfoxes wants to merge 3 commits intomainfrom
Open
fix: Add all attachments when CaptureFeedback#5077bitsandfoxes wants to merge 3 commits intomainfrom
CaptureFeedback#5077bitsandfoxes wants to merge 3 commits intomainfrom
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
==========================================
- Coverage 74.00% 74.00% -0.01%
==========================================
Files 499 499
Lines 18066 18067 +1
Branches 3518 3519 +1
==========================================
Hits 13370 13370
- Misses 3837 3838 +1
Partials 859 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It was just copied from the JS SDK which does have this restriction, but that's just a browser/JS thing, not a protocol thing so we should remove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on: #3981
I could not find any source, neither in the dev docs nor on Sentry, for the "only one attachment per feeedback" restriction. The envelop created from a feedback can hold as many attachments as any other and will get processed by Sentry accordingly.