feat: Add network details for session replay on iOS#4891
Open
jamescrosswell wants to merge 29 commits intomainfrom
Open
feat: Add network details for session replay on iOS#4891jamescrosswell wants to merge 29 commits intomainfrom
jamescrosswell wants to merge 29 commits intomainfrom
Conversation
… .NET and Java replay breadcrumbs
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add network details for session replay on iOS ([#4891](https://github.com/getsentry/sentry-dotnet/pull/4891))If none of the above apply, you can opt out of this check by adding |
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4891 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 499 499
Lines 18065 18066 +1
Branches 3518 3518
=======================================
+ Hits 13370 13372 +2
+ Misses 3836 3835 -1
Partials 859 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed:
ToCocoaBreadcrumbDatais never called in production codeBreadcrumbExtensions.ToCocoaBreadcrumbnow usesToCocoaBreadcrumbData, sorequest_startis converted toNSDatefor Cocoa Session Replay network breadcrumb parsing.
Or push these changes by commenting:
@cursor push d93cff9153
Preview (d93cff9153)
diff --git a/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs b/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
--- a/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
+++ b/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
@@ -19,7 +19,7 @@
Timestamp = breadcrumb.Timestamp.ToNSDate(),
Message = breadcrumb.Message,
Type = breadcrumb.Type,
- Data = breadcrumb.Data?.ToNullableNSDictionary(),
+ Data = breadcrumb.Data?.ToCocoaBreadcrumbData(),
Category = breadcrumb.Category ?? "",
Level = breadcrumb.Level.ToCocoaSentryLevel()
};This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4890:
Remarks
There are a couple of things about this PR that make me nervous:
EnableSessionReplayInUnreliableEnvironmentI'd recommend we leave this experimental for quite some time to try to get a feel for whether either of these things is going to be a deal breaker.
Example