Open
Conversation
jjbayer
commented
Feb 17, 2026
| /// | ||
| /// Returns an empty [`Err`] if the project config cannot be resolved in the given time. | ||
| pub async fn ready_project(&self, timeout: Duration) -> Result<SharedProject, ()> { | ||
| tokio::time::timeout(timeout, self.ready_project_inner()) |
Member
Author
There was a problem hiding this comment.
It might be slightly more elegant to put the timeout in the outermost function, but this way it is unit-testable.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Register the Notified future before checking the pending state to prevent missed notifications from notify_waiters(). Also fixes a snapshot inconsistency where to_shared_project() could load a different state than the one checked. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to await the resolution of a project (i.e. for it to become non-pending).
Needed for #5638.