[STREAM-611] Move Launchpad to Taskbroker#561
Draft
james-mcnulty wants to merge 6 commits intomainfrom
Draft
Conversation
Member
Author
Input (Sentry CLI)Output (Launchpad) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Used the new taskbroker / taskworker Python client to process Launchpad tasks emitted from within the Sentry monolith. This is part of the initiative to enable "external" taskworkers (that is, taskworkers that are external to the Sentry monolith).
Details
LAUNCHPAD_WORKER_RPC_HOSTandLAUNCHPAD_WORKER_CONCURRENCY) for taskworker configurationgrpcio, which does not have prebuilt wheels for Python 1.13LaunchpadService, replaced withTaskWorkerthat starts whensetupis calledSee getsentry/sentry#107442 for monolith changes (task stub).