Set arroyo's max_pending_futures to 0#513
Merged
NicoHinderling merged 1 commit intomainfrom Dec 5, 2025
Merged
Conversation
trevor-e
approved these changes
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 164 164
Lines 14213 14213
Branches 1501 1501
=======================================
Hits 11500 11500
Misses 2144 2144
Partials 569 569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simpler alternative to #512. Given how slow our average processing time is, we don't gain much performance benefit from the prefetching and this also solves the problem described in that PR.
The only downside of this approach is that if we set our consumer's concurrency > 1, arroyo may not use that extra concurrency because it wouldn't accept another pending future... so if we ever want to have concurrency > 1, we'll want to do the #512 approach, but we should be far away from needing to do that (and can just scale up the number of pods instead)