Open
Conversation
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
chromy
force-pushed
the
chromy/2025-10-03-use-uv
branch
20 times, most recently
from
523b041 to
1a9c82c
Compare
chromy
force-pushed
the
chromy/2025-10-03-use-uv
branch
from
1a9c82c to
83afe72
Compare
trevor-e
approved these changes
Oct 14, 2025
| "google-api-python-client==2.181.0", | ||
| "lief==0.16.6", | ||
| "lzfse>=0.4.2", | ||
| "pillow>=11.3.0", |
Member
There was a problem hiding this comment.
Can we try locking everything to a specific version or should we do that in a follow-up step?
| $(VENV_DIR)/bin/pre-commit install | ||
| # Python, uv, and Python requirements (core and dev) installed via | ||
| # the github workflow. | ||
| install-dev-for-ci: |
Member
There was a problem hiding this comment.
nit: if this is CI-specific maybe just do it directly in the workflow? e.g. it's already calling uv sync --frozen --active and not using a makefile command for that, but don't have a strong opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomluv.lock)uv/.python-versionsimplifyingsync.pyDockerfile,Makefile, and github workflows to reflect the above.This aligns us much closer with the new suggested setup for Python:
https://www.notion.so/sentry/Standard-Spec-python-uv-2248b10e4b5d8045b8fff30f8b8b67ca
Fixes EME-212
Prepares to fix EME-213