Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Wallet recurring transaction rules of type
targetpreviously always created a paid top-up; there was no way to grant free credits through a target rule. The API now supports this via a nullable booleangrants_target_top_upon the recurring transaction rule (getlago/lago-api#5582). On atargetrule,truemakes the periodic gap-fill grant free credits to reach the target balance instead of creating a paid top-up;false, the default for target rules, keeps the current paid behaviour. The field isnullforfixedrules.Description
Exposes
grants_target_top_upso consumers can set it on wallet create/update:grants_target_top_upin the recurring transaction rule params. Responses already surface it (parsed dynamically intoOpenStruct), so no response-model change is needed.No version bump: released separately, per repo convention.
How to try locally