Skip to content

[ING-30] test: Cover currency filter on list endpoints #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aquinofb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ING-30] test: Cover currency filter on list endpoints #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ac2ac5
[ING-30] test: Cover currency filter on lists
aquinofb May 27, 2026
8a67933
[ING-30] test: Assert the currency query param explicitly
aquinofb Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions spec/lago/api/resources/payment_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@
end
end

context 'when currency is given' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/payment_requests?currency=EUR')
.to_return(body: payment_requests_response, status: 200)
end

it 'forwards the currency option as a query param' do
resource.get_all({ currency: 'EUR' })

expect(WebMock).to have_requested(:get, 'https://api.getlago.com/api/v1/payment_requests')

@groyoh groyoh Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have to mock webmock since we're already stubbing. 🤔

.with(query: { currency: 'EUR' })
end
end
Comment on lines +99 to +111

@toommz toommz Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it returns the same results as the when there is no options context, I don't really see the added value of this example 🤔


context 'when there is an issue' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/payment_requests')
Expand Down
14 changes: 14 additions & 0 deletions spec/lago/api/resources/subscription_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,20 @@
end
end

context 'when currency is given' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/subscriptions?currency=EUR')
.to_return(body: response, status: 200)
end

it 'forwards the currency option as a query param' do
resource.get_all({ currency: 'EUR' })

expect(WebMock).to have_requested(:get, 'https://api.getlago.com/api/v1/subscriptions')
.with(query: { currency: 'EUR' })
end
end

context 'when status is given' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/subscriptions?external_customer_id=123&status%5B%5D=pending')
Expand Down
14 changes: 14 additions & 0 deletions spec/lago/api/resources/wallet_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,20 @@
end
end

context 'when currency is given' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/wallets?currency=EUR')
.to_return(body: response, status: 200)
end

it 'forwards the currency option as a query param' do
resource.get_all({ currency: 'EUR' })

expect(WebMock).to have_requested(:get, 'https://api.getlago.com/api/v1/wallets')
.with(query: { currency: 'EUR' })
end
end

context 'when there is an issue' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/wallets')
Expand Down
Loading