-
Notifications
You must be signed in to change notification settings - Fork 1
P-1525 React Native SDK #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
320cd46
P-1525 React Native SDK
yosriady 239fc7c
Fix TypeScript build errors
yosriady d2fe5aa
Fix cleanup race condition and reset session state
yosriady 2760ad2
Fix race conditions and consent key collision
yosriady be619e2
Fix event deduplication and wagmi config tracking
yosriady 610d344
Fix multiple bugs identified in code review
yosriady fbb0953
Fix multiple bugs from code review
yosriady 29ee10e
Simplify consent key and document deduplication behavior
yosriady 08b75a5
Improve security and fix chain tracking issues
yosriady 235af1d
Fix recursive call in status change processing
yosriady 721af74
Improve useFormo hook and cleanup error handling
yosriady 389ea2b
Fix code review issues: options ref, flush mutex, cleanup leak
yosriady f4f90a7
Fix Date object corruption in toSnakeCase
yosriady ae27956
Add error handling for flush() in enqueue threshold check
yosriady b30eef2
Fix cleanup() to flush all queued events
yosriady 27c6836
Fix storage fallback caching and chainId validation consistency
yosriady 5e04c24
push
yosriady f783740
Add rdns to connect event from wagmi integration
yosriady abb689f
Add chainId validation to handleSignatureMutation
yosriady b3ea77f
Make chainId required for signature() method
yosriady 8262340
fix build warnings
yosriady 5c8c95c
Add enhanced mobile context properties and UTM tracking
yosriady 21d8f4b
Use full SHA-256 hash for message_id to match web SDK format
yosriady 151e8a3
Add unit tests
yosriady 3ef6db7
Fix type interface, cleanup safety, and provider race condition
yosriady b5e3ea2
Add CI workflow for running tests and build
yosriady 461249c
update lockfile
yosriady cd3668a
Fix CI workflow pnpm version conflict and duplicate runs
yosriady 89bdafc
Fix CI workflow and TypeScript errors in tests
yosriady e8025f3
Add Expo Go compatibility for device info
yosriady bbb5088
Fix CI lockfile issue and add missing test mocks
yosriady 786f73f
Use --no-frozen-lockfile in CI to handle package.json updates
yosriady a67ff3e
Fix Jest configuration and useFormo warning spam
yosriady 2e5d788
Use --frozen-lockfile in CI for reproducible builds
yosriady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, master] | ||
| pull_request: | ||
| branches: [main, master] | ||
|
|
||
| # Cancel in-progress runs when a new commit is pushed | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Run type check | ||
| run: pnpm run typecheck | ||
|
|
||
| - name: Run tests with coverage | ||
| run: pnpm run test:coverage | ||
|
|
||
| - name: Upload coverage reports | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| fail_ci_if_error: false | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| build: | ||
| runs-on: ubuntu-latest | ||
| needs: test | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Build | ||
| run: pnpm run build | ||
|
|
||
| - name: Verify build output exists | ||
| run: | | ||
| test -d lib/commonjs || (echo "lib/commonjs not found" && exit 1) | ||
| test -d lib/module || (echo "lib/module not found" && exit 1) | ||
| test -d lib/typescript || (echo "lib/typescript not found" && exit 1) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| node_modules | ||
|
|
||
| # Build output (top-level lib/ directory only, not src/lib/) | ||
| /lib/ | ||
|
|
||
| # IDE | ||
| .idea/ | ||
| .vscode/ | ||
| *.swp | ||
| *.swo | ||
|
|
||
| # OS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Test coverage | ||
| coverage/ | ||
|
|
||
| # Logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| # Environment | ||
| .env | ||
| .env.local | ||
| .env.*.local |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI runs tests twice causing redundant execution
Low Severity
The CI workflow runs tests twice sequentially: first with
pnpm test(which executesjest) and then withpnpm run test:coverage(which executesjest --coverage). Sincejest --coverageruns all tests while also collecting coverage, the first test run is redundant and doubles CI execution time unnecessarily. Only the coverage run is needed.