fix(models): Handle RangeError in sizeof for large objects #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dividedmind
added
the
build native
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a RangeError that occurs when the sizeof utility function attempts to calculate the size of very large AppMap objects. The fix introduces a fallback recursive calculation when JSON.stringify fails due to V8's string length limitations.
Key Changes
- Modified
sizeoffunction to catch RangeError and use recursive size calculation as fallback - Added comprehensive unit tests for the
sizeoffunction including the RangeError fallback scenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/models/src/util.js | Added try-catch block to sizeof with recursive fallback logic for arrays, objects, and strings when JSON.stringify throws RangeError |
| packages/models/tests/unit/sizeof.spec.js | New test file with unit tests covering basic sizeof functionality and RangeError fallback behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses RangeError: Invalid string length when pruning large AppMaps by modifying the `sizeof` utility function in `@appland/models`. Previously, `sizeof` relied solely on `JSON.stringify(obj).length`, which can fail with `RangeError` for very large JavaScript objects (exceeding V8's string length limits). This in turn led to an uninitialized `classMap` and a subsequent `TypeError` during AppMap pruning. This change introduces a `try...catch` block around `JSON.stringify`. If a `RangeError` occurs, `sizeof` now falls back to a recursive calculation of the object's approximate serialized size. This ensures that large AppMaps can be processed without crashing. A new unit test `sizeof.spec.js` has been added to `packages/models/tests/unit/` to specifically verify this fallback mechanism using Jest mocks.
Update the build script to split 'macro.yml' content by either '\n' or '\r\n'. This fixes a build failure on Windows where carriage returns were causing regex matching to fail when parsing the YAML file.
dividedmind
force-pushed
the
fix/large-appmap-pruning
branch
from
dd6c967 to
e8abce7
Compare
Contributor
|
🎉 This PR is included in version @appland/appmap-validate-v2.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses RangeError: Invalid string length when pruning large AppMaps by modifying the
sizeofutility function in@appland/models.Previously,
sizeofrelied solely onJSON.stringify(obj).length, which can fail withRangeErrorfor very large JavaScript objects (exceeding V8's string length limits). This in turn led to an uninitializedclassMapand a subsequentTypeErrorduring AppMap pruning.This change introduces a
try...catchblock aroundJSON.stringify. If aRangeErroroccurs,sizeofnow falls back to a recursive calculation of the object's approximate serialized size. This ensures that large AppMaps can be processed without crashing.A new unit test
sizeof.spec.jshas been added topackages/models/tests/unit/to specifically verify this fallback mechanism using Jest mocks.