Skip to content

Conversation

@renner0e
Copy link
Collaborator

image

poggers:
fastfetch-cli/fastfetch#2151

we are hitting this with 6.6 lol:
fastfetch-cli/fastfetch#2150

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fastfetch configuration, likely to support a newer version of the tool and address some outdated settings. The changes include updating color formats, changing icons, and adjusting the displayed modules. Overall, these changes improve the fastfetch output.

I've found one issue with a newly added command to display the $EDITOR version. It doesn't handle the case where the $EDITOR environment variable is not set, which would lead to an error. I've provided a suggestion to make this command more robust.

Comment on lines 121 to 125
"type": "command",
"text": "$EDITOR --version | head -1",
"key": "",
"keyColor": "",
"format": "{1}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This command will fail if the $EDITOR environment variable is not set, which would cause an error to be printed to stderr. It's better to add a check to see if $EDITOR is set before trying to execute it. This also requires specifying a shell to run the conditional logic.

      "type": "command",
      "shell": "/bin/bash",
      "text": "if [ -n \"$EDITOR\" ]; then $EDITOR --version | head -1; fi",
      "key": "",
      "keyColor": "",
      "format": "{1}"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an issue in practice because if this fails it will not print anything by default
image

Copy link

@ledif ledif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the separation of Flatpak and Brew packages.

@hanthor hanthor added this pull request to the merge queue Jan 17, 2026
Merged via the queue into main with commit e300e9a Jan 17, 2026
1 check passed
@hanthor hanthor deleted the fastfetch-impr branch January 17, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants