-
Notifications
You must be signed in to change notification settings - Fork 8
feat: make fastfetch better #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the fastfetch configuration, likely to support a newer version of the tool and address some outdated settings. The changes include updating color formats, changing icons, and adjusting the displayed modules. Overall, these changes improve the fastfetch output.
I've found one issue with a newly added command to display the $EDITOR version. It doesn't handle the case where the $EDITOR environment variable is not set, which would lead to an error. I've provided a suggestion to make this command more robust.
| "type": "command", | ||
| "text": "$EDITOR --version | head -1", | ||
| "key": "", | ||
| "keyColor": "", | ||
| "format": "{1}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command will fail if the $EDITOR environment variable is not set, which would cause an error to be printed to stderr. It's better to add a check to see if $EDITOR is set before trying to execute it. This also requires specifying a shell to run the conditional logic.
"type": "command",
"shell": "/bin/bash",
"text": "if [ -n \"$EDITOR\" ]; then $EDITOR --version | head -1; fi",
"key": "",
"keyColor": "",
"format": "{1}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ledif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the separation of Flatpak and Brew packages.

poggers:
fastfetch-cli/fastfetch#2151
we are hitting this with 6.6 lol:
fastfetch-cli/fastfetch#2150