Skip to content

Dynamic filter widget: Registered interactions clean up after any target node gets deleted #12017#12043

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
rowheat02:interactionCleanup
Mar 13, 2026
Merged

Dynamic filter widget: Registered interactions clean up after any target node gets deleted #12017#12043
offtherailz merged 1 commit intogeosolutions-it:masterfrom
rowheat02:interactionCleanup

Conversation

@rowheat02
Copy link
Contributor

Description

This PR fixes filter widget interactions cleanup after layer deletion.

Problem: When a linked map layer is deleted, stale interaction entries can remain in the filter widget and still be processed, causing an unstable state.

Implemented solution: on REMOVE_NODE for layers, the interactions epic now removes filter-widget interactions that target the deleted map.layers[layerId]. This ensures cleanup happens immediately after deletion and no dead interaction is processed.

Screen.Recording.2026-03-03.at.16.34.14.mov

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#12017
After deleting a connected layer, stale interactions may remain in filter widget interactions, and dead interactions can still be processed, resulting unstable system.

What is the new behavior?
After deleting a layer, related filter-widget interactions are cleaned up. No dead interaction will be processed.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2026.01.00 milestone Mar 3, 2026
@rowheat02 rowheat02 requested a review from offtherailz March 3, 2026 10:52
@rowheat02 rowheat02 added the bug label Mar 3, 2026
@cla-bot cla-bot bot added the CLA Ready label Mar 3, 2026
@rowheat02 rowheat02 marked this pull request as ready for review March 3, 2026 11:00
@offtherailz offtherailz merged commit 4437da3 into geosolutions-it:master Mar 13, 2026
14 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

@offtherailz
Copy link
Member

@ElenaGallo
Copy link
Contributor

Test passed, @rowheat02 please backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic filter widget: Registered interactions clean up after any target node gets deleted

3 participants