Skip to content

Add new CPP flag for carbon Jacobian runs#538

Merged
yantosca merged 1 commit intodev/no-diff-to-benchmarkfrom
feature/jacobian_tracers
Apr 1, 2026
Merged

Add new CPP flag for carbon Jacobian runs#538
yantosca merged 1 commit intodev/no-diff-to-benchmarkfrom
feature/jacobian_tracers

Conversation

@lizziel
Copy link
Copy Markdown
Contributor

@lizziel lizziel commented Mar 19, 2026

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR introduces a new build flag for carbon Jacobian runs in GCHP. Building with -DJACOBIAN during CMake configure will turn on the feature.

This PR should be merged at the same time as:

Expected changes

This is a no diff update for all simulations.

Reference(s)

None

Related Github Issue

Coming soon

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Carbon Simulation Specific to GCHP carbon simulation labels Mar 19, 2026
@lizziel lizziel marked this pull request as draft March 19, 2026 19:42
@lizziel lizziel requested a review from yantosca March 24, 2026 13:15
@lizziel lizziel marked this pull request as ready for review March 24, 2026 13:16
@lizziel lizziel added this to the 14.7.1 milestone Mar 24, 2026
Copy link
Copy Markdown
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizzlel. Good to merge!

@yantosca
Copy link
Copy Markdown
Contributor

I have merged locally and am running integration tests.

@yantosca yantosca merged commit 83b7303 into dev/no-diff-to-benchmark Apr 1, 2026
1 check passed
@yantosca yantosca deleted the feature/jacobian_tracers branch April 1, 2026 16:05
@yantosca
Copy link
Copy Markdown
Contributor

yantosca commented Apr 1, 2026

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

CodeDir   : 42e86f2 PR #3080 post-merge hotfix: Fix incorrect id_CO2, id_CO indices
GEOS-Chem : 0ef2d016e Hotfix: Fix typo in PR #3080 causing id_CO and id_CO2 to be swapped
HEMCO     : 9fbb78e Merge PR #355 (Update to latest GitHub Actions versions)
Cloud-J   : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP      : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Using 24 OpenMP threads
Number of execution tests: 38

Submitted as SLURM job: 3015072
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GEOS-Chem Classic tests were zero-diff w/r/t gcc.4.82cf094, except

  • gc_4x5_merra2_fullchem_APM
    • Parallel error (known issue)

@yantosca
Copy link
Copy Markdown
Contributor

yantosca commented Apr 2, 2026

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

CodeDir       : b6be053 PR #3080 post-merge hotfix: Fix incorrect id_CO2, id_CO indices
MAPL          : d1d528e5 Merge pull request #39 from geoschem/feature/mapl_2.55.0
GMAO_Shared   : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake    : 01bbf2f Merge pull request #9 from geoschem/feature/turn_off_f2py_builds_in_gchp
FMS           : 259759d1 Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : 348620f Merge PR #11 (Scale tracers by pressure ratio in first timestep)
geos-chem     : 0ef2d016e Hotfix: Fix typo in PR #3080 causing id_CO and id_CO2 to be swapped
HEMCO         : 9fbb78e Merge PR #355 (Update to latest GitHub Actions versions)
Cloud-J       : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP          : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
GFE           : bac529f Merge pull request #40 from Goddard-Fortran-Ecosystem/feature/mathomp4/update-gftl-1.15.2

Number of execution tests: 12

Submitted as SLURM job: 3042779
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP tests were zero-diff w/r/t gchp.4.104279d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Carbon Simulation Specific to GCHP carbon simulation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants