fix support for custom formatters (#1997) #2144
Conversation
tomkralidis
changed the title
tomkralidis
force-pushed
the
formatters
branch
2 times, most recently
from
dbbce65 to
b364419
Compare
tomkralidis
force-pushed
the
formatters
branch
from
b364419 to
051ccbb
Compare
tomkralidis
force-pushed
the
formatters
branch
from
051ccbb to
4ae51b6
Compare
tomkralidis
changed the title
webb-ben
left a comment
webb-ben
left a comment
There was a problem hiding this comment.
Looks good to me. I will test later today. Some small questions / comments.
-
This implements custom formatters for OAFeat and OARec GeoJSON responses. Can we add some additional documentation to clarify this? Is support for EDR CovJSON Formatters an entirely different issue? I have a simple Point-based CovJSON -> CSV formatter that I would like to synchronize these changes with.
-
After this is merged I will migrate our OGR Formatter to https://github.com/cgs-earth/pygeoapi-plugins. I will want to figure out how much of this can be offloaded to the configuration options introduced. Depending on the path this takes, a general OGR formatter could subsume #2136 and our custom formatter.
| self.mimetype = None | ||
| self.geom = False | ||
|
|
||
| self.name = formatter_def['name'] |
There was a problem hiding this comment.
For some reason this is formatted to the wrong line. In the base provider, all required fields are in a try/catch. Should
self.name = formatter_def['name']
follow suit?
| super().__init__({'name': 'cooljson', 'geom': None}) | ||
| self.mimetype = 'application/json; subtype:mycooljson' | ||
| self.f = 'cooljson' # f= value |
There was a problem hiding this comment.
Does the formatter need to response both f= and the Accept Header?
| formatter = load_plugin('formatter', | ||
| {'name': 'CSV', 'geom': True}) | ||
| elif request.format in [df.f for df in dataset_formatters.values()]: | ||
| formatter = [v for k, v in dataset_formatters.items() if |
There was a problem hiding this comment.
| formatter = [v for k, v in dataset_formatters.items() if | |
| formatter = [v for v in dataset_formatters.values() if |
Are we using the key in this?
Overview
This PR updates formatters support to allow for custom formatters for item types.
Related Issue / discussion
#1997
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)