Hotfix 6.3.x sup 19628#827
Open
plyhun wants to merge 4 commits into
Open
Conversation
plyhun
commented
Jul 2, 2026
| @Parameters(name = "{index}: user ID {0}") | ||
| public static Collection<Object[]> data() { | ||
| // 1 for system, 3 for super admin | ||
| return List.of(new Object[] { 1 }, new Object[] { 3 }); |
Contributor
Author
There was a problem hiding this comment.
I am a bit worried that most of our data manipulation tests use system group, and not the Super Admin one, whose possibilities are limited.
plyhun
commented
Jul 2, 2026
| await tab.click(); | ||
| const actionButtons = page.locator('gtx-group-detail gtx-tab[data-id="subgroups"] .entity-table-actions-bar'); | ||
| await actionButtons.waitFor(); | ||
| expect(actionButtons.locator('.table-action-button button.btn').filter({ hasText: 'Neue Untergruppe erstellen' })).toBeVisible(); |
Contributor
Author
There was a problem hiding this comment.
Yes, I do remember using data-* instead of text content. Somehow they are not working for my setup, as expected :(
plyhun
commented
Jul 2, 2026
| get(userId: number): Observable<Group<Raw>> { | ||
| return this.api.group.getGroup(userId).pipe( | ||
| return this.api.group.getGroup(userId, { perms: true }).pipe( | ||
| tap((res: GroupResponse) => this.permissions.storePermissions(AccessControlledType.GROUP_ADMIN, res.group.id, res.perms || GcmsPermission.VIEW)), |
Contributor
Author
There was a problem hiding this comment.
This obviously won't work without backend changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.