This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Linted INSTALL script#17
Open
miguelbernadi wants to merge 1 commit intogenome:masterfrom
miguelbernadi:patch-1
Open
Linted INSTALL script#17miguelbernadi wants to merge 1 commit intogenome:masterfrom miguelbernadi:patch-1
miguelbernadi wants to merge 1 commit intogenome:masterfrom
miguelbernadi:patch-1
Conversation
INSTALL script didn't properly validate input and did many string comparisons were number comparisons would be better. Passed through http://www.shellcheck.net/ to make sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTALL script didn't properly validate input and did many string comparisons were number comparisons would be better. Passed through http://www.shellcheck.net/ to make sure.