feat(js/plugins/middleware): implemented tool approval middleware#5055
feat(js/plugins/middleware): implemented tool approval middleware#5055pavelgj merged 27 commits intopj/gm-middleware-filesystemfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a suite of middlewares for the Genkit JS SDK, including filesystem access, skill injection, tool approval, retries, and fallbacks. The feedback identifies a configuration error in the README regarding the skills middleware and notes a dependency on internal framework APIs within the toolApproval implementation that could benefit from better documentation or a more stable interface.
…proval metadata access
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the toolApproval middleware to the Genkit JS SDK, which enables restricting tool execution to an approved list and supports manual approval workflows via ToolInterruptError. The changes include the middleware implementation, documentation in the README, a coding agent example, and unit tests. Review feedback recommends improving type safety by replacing any types with specific interfaces in the example script and the middleware logic.
… naming conventions
2 participants
No description provided.