Fix parsing of one-to-one metadata#388
Open
marcellevstek wants to merge 1 commit intogenialis:masterfrom
Open
Conversation
Member
|
@marcellevstek Rebase, write change log entry, update docs (if needed). |
97dfd76 to
6c37e9a
Compare
Contributor
Author
|
@gregorjerse this PR addresses the issue when a one-to-one metadata table object includes samples that are either not present in the collection or don't have a required data object of certain process type (e.g. MultiQC). Previously the code failed, which posed an issue if some samples imported from GEO failed to process and we wanted to remove them from the collection. When you import through GEO, a one-to-one metadata table is created for each of the imported samples. Here is some testing code. Try it with this branch versus the master branch to see the difference. |
7a70e8c to
45b2df3
Compare
for samples with no data objects of certain process type or missing samples in the collection
45b2df3 to
32bb857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.