Secondary action fee

[ashhanai]

Implement secondary action fee that is charged during deposit/mint if withdraw/redeem occurred in the same transaction. Fee size is configurable by Config Manager.

[carlosgj94]

Code looks good, I didn't see any particular problem.
Just to be 100% (this is an upgrade after all), I added a comment.

[carlosgj94]

Although transient storage should not alter the storage layout, would you mind generating a before and after of forge inspect storage --pretty?
That should ensure us we are not messing it. Just to fully double check, this is a critical component.

[ashhanai]

Original storage:

Name	Type	Slot	Offset	Bytes
paused	bool	0	0	1
skipNextRebalanceSafetyBufferCheck	bool	0	1	1
_share	contract IGenericShare	0	2	20
priceFeeds	mapping(address => struct BaseController.PriceFeed)	1	0	32
vaultSettings	mapping(address => struct BaseController.VaultSettings)	2	0	32
_vaultFor	mapping(address => address)	3	0	32
_vaults	mapping(address => address)	4	0	32
_vaultsCount	uint8	5	0	1
maxProtocolRebalanceSlippage	uint16	5	1	2
rewardsCollector	address	5	3	20
isRewardAsset	mapping(address => bool)	6	0	32
_swapper	contract ISwapper	7	0	20
_yieldDistributor	contract IYieldDistributor	8	0	20
safetyBufferYieldDeduction	uint256	9	0	32
__gap	uint256[50]	10	0	1600

Updated storage:

Name	Type	Slot	Offset	Bytes
paused	bool	0	0	1
skipNextRebalanceSafetyBufferCheck	bool	0	1	1
_share	contract IGenericShare	0	2	20
priceFeeds	mapping(address => struct BaseController.PriceFeed)	1	0	32
vaultSettings	mapping(address => struct BaseController.VaultSettings)	2	0	32
_vaultFor	mapping(address => address)	3	0	32
_vaults	mapping(address => address)	4	0	32
_vaultsCount	uint8	5	0	1
maxProtocolRebalanceSlippage	uint16	5	1	2
rewardsCollector	address	5	3	20
isRewardAsset	mapping(address => bool)	6	0	32
_swapper	contract ISwapper	7	0	20
_yieldDistributor	contract IYieldDistributor	8	0	20
safetyBufferYieldDeduction	uint256	9	0	32
secondaryActionFee	uint16	10	0	2
__gap	uint256[49]	11	0	1568

You can see that the transient properties are not even there. The new secondaryActionFee is at the end even though it fits after _share address.

[carlosgj94]

lgtm