Check vaults cannot get into deadlock#179
Merged
Merged
Conversation
carlosgj94
requested changes
Dec 2, 2025
Contributor
carlosgj94
left a comment
carlosgj94
left a comment
There was a problem hiding this comment.
Wouldn't this change still allow for a setting in which two vaults each at 50% hit a deadlock?
I very much like the direction of this PR, always bet on our own stupidity, and this makes it easier not to fuck it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that sum of any two max proportionality limits is greater than or equal to 100% after adding, removing, and updating vault settings.