Skip to content

Add additional safety checks to rebalancing#176

Merged
carlosgj94 merged 5 commits into
mainfrom
fix/rebalancing
Dec 2, 2025
Merged

Add additional safety checks to rebalancing#176
carlosgj94 merged 5 commits into
mainfrom
fix/rebalancing

Conversation

@ashhanai
Copy link
Copy Markdown
Collaborator

@ashhanai ashhanai commented Nov 26, 2025

Changes

  • swapper executor (that is provided by 1inch API) is now trustless and swapper does not need owner

Note: needed to rearrange internal function parameters to solve stack too deep

@ashhanai ashhanai requested a review from carlosgj94 November 26, 2025 15:59
Copy link
Copy Markdown
Contributor

@carlosgj94 carlosgj94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, actually... why are we removing the whitelisting of the executors?
I know we have the slippage check, but still, it seems like fair protection with low downside, no?

@carlosgj94 carlosgj94 self-requested a review December 1, 2025 10:25
@ashhanai
Copy link
Copy Markdown
Collaborator Author

ashhanai commented Dec 1, 2025

Executor is trustless even in the 1inch contract, which I didn't know when I was writing the contract. It doesn't matter who is doing the swap as long as the output parameter are met (you get the right amount of the right asset). The executor allowlist is an unnecessary code + the executor is changing so we would have to approve it quite often.

@carlosgj94 carlosgj94 merged commit ed5016a into main Dec 2, 2025
2 checks passed
@carlosgj94 carlosgj94 deleted the fix/rebalancing branch December 2, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants