Add additional safety checks to rebalancing#176
Merged
Conversation
carlosgj94
approved these changes
Dec 1, 2025
Collaborator
Author
|
Executor is trustless even in the 1inch contract, which I didn't know when I was writing the contract. It doesn't matter who is doing the swap as long as the output parameter are met (you get the right amount of the right asset). The executor allowlist is an unnecessary code + the executor is changing so we would have to approve it quite often. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Note: needed to rearrange internal function parameters to solve stack too deep