This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Add gem_keystore crate with BIP39 recovery phrase suggestions#1154
Closed
0xh3rman wants to merge 1 commit into
Closed
Add gem_keystore crate with BIP39 recovery phrase suggestions#11540xh3rman wants to merge 1 commit into
0xh3rman wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new gem_keystore crate and a keystore module within the gemstone package to provide mnemonic word suggestions based on the BIP39 standard. The implementation includes a suggest_recovery_phrase_words function exported via UniFFI for cross-platform support. Feedback indicates that the suggestion logic should normalize input to lowercase to ensure case-insensitive matching against the wordlist. Additionally, there is a concern regarding performance overhead when returning the full 2048-word list for empty prefixes during FFI serialization, suggesting a limit should be applied.
Introduce gem_keystore as the foundation crate for keystore and key management work. Initial surface is a Mnemonic helper that exposes BIP39 English word suggestions, wired through gemstone via UniFFI as suggest_recovery_phrase_words.
0xh3rman
force-pushed
the
recovery-phrase-suggest
branch
from
50d5711 to
ad6e6e8
Compare
Collaborator
Author
|
will be included in full keystore pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce gem_keystore as the foundation crate for keystore and key management work. Initial surface is a Mnemonic helper that exposes BIP39 English word suggestions, wired through gemstone via UniFFI as suggest_recovery_phrase_words.