Skip to content

add tests almost finished#40

Open
rachel-yos wants to merge 2 commits into
gemtechd:mainfrom
rachel-yos:main
Open

add tests almost finished#40
rachel-yos wants to merge 2 commits into
gemtechd:mainfrom
rachel-yos:main

Conversation

@rachel-yos

Copy link
Copy Markdown

No description provided.

@rachel-yos rachel-yos closed this Aug 6, 2024
@rachel-yos

Copy link
Copy Markdown
Author

merge main with tests in the first time

@rachel-yos rachel-yos reopened this Aug 6, 2024

@gemtechd gemtechd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the code also
because the code misses some checks before the tests

@rachel-yos

rachel-yos commented Aug 7, 2024 via email

Copy link
Copy Markdown
Author

@gemtechd

gemtechd commented Aug 7, 2024

Copy link
Copy Markdown
Owner
  1. everyone wrote the task, and every girl got the review the same way
  2. You need to make better the code, for example check the code that the function got all parameters
  3. You need to go through the first task with a little bit frustration that the next task you'll be on the right path from the beginning,
  4. btw you were invited a long time ago to the github - this things are up to you

@rachel-yos

rachel-yos commented Aug 7, 2024 via email

Copy link
Copy Markdown
Author

@rachel-yos

Copy link
Copy Markdown
Author

I made a new commit , but I don't see that in the pull requests, only in mine.
It is looks like a conflict of merging, but there is no way to solve it, no button of clue.

@gemtechd

gemtechd commented Aug 7, 2024

Copy link
Copy Markdown
Owner

Send it to a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants