Skip to content

fixed bug with null reads due to lack of decoration #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gcsantos-gpa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug with null reads due to lack of decoration #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Gemstone.Web/APIController/ReadOnlyModelController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@
/// </summary>
/// <param name="id">The PrimaryKey value of the Model to be returned.</param>
/// <param name="cancellationToken">Propagates notification that operations should be canceled.</param>
/// <returns>An <see cref="IActionResult"/> containing a <see cref="T"/> or <see cref="Exception"/>.</returns>

Check warning on line 309 in src/Gemstone.Web/APIController/ReadOnlyModelController.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

XML comment has cref attribute 'T' that refers to a type parameter
[HttpGet, Route("One/{id}")]
public virtual async Task<IActionResult> GetOne(string id, CancellationToken cancellationToken)
{
Expand Down Expand Up @@ -359,7 +359,7 @@
/// <returns>A <see cref="PageInfo"/> object containing the pagination information or <see cref="Exception"/>.</returns>
[HttpPost, Route("PageInfo/{parentID?}")]
[ResourceAccess(ResourceAccessType.Read)]
public virtual async Task<IActionResult> GetPageInfo(SearchPost<T> postData, string? parentID, CancellationToken cancellationToken)
public virtual async Task<IActionResult> GetPageInfo([FromBody] SearchPost<T> postData, string? parentID, CancellationToken cancellationToken)
{
await using AdoDataConnection connection = CreateConnection();
TableOperations<T> tableOperations = new(connection);
Expand Down Expand Up @@ -423,7 +423,7 @@
/// Gets a new record.
/// </summary>
/// <param name="cancellationToken">Propagates notification that operations should be canceled.</param>
/// <returns>A <see cref="T"/> object or <see cref="Exception"/>.</returns>

Check warning on line 426 in src/Gemstone.Web/APIController/ReadOnlyModelController.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

XML comment has cref attribute 'T' that refers to a type parameter
[HttpGet, Route("New")]
public virtual async Task<IActionResult> New(CancellationToken cancellationToken)
{
Expand Down
Loading