Skip to content

Handle unparseable JSON response for API requests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stensrud wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle unparseable JSON response for API requests #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106f1ec
Handle unparseable JSON response for API requests
stensrud Nov 10, 2016
67da0cd
Update api-request.js
stensrud Nov 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/api-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,23 @@ module.exports = {
return;
}
if (response.statusCode >= 200 && response.statusCode < 300) {
cb(null, JSON.parse(body));
var json;
try {
json = JSON.parse(body);
} catch (ex) {
return cb(new Error('Unparseable response'));
}
cb(null, json);
} else {
cb(new Error(JSON.parse(body).error.message));
var json;
try {
json = JSON.parse(body);
} catch (ex) {
return cb(new Error('Unparseable response'));
}
if (!json||!json.error||!json.error.message)
return cb(new Error('Unknown error'));
cb(new Error(json.error.message));
}
}
const requestOptions = {
Expand Down