Skip to content

parse Ellipse extrusionDirection #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FishOrBear wants to merge 2 commits into
base: master
Choose a base branch
from
Open

parse Ellipse extrusionDirection #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a897a
parse Ellipse extrusionDirection
Mar 29, 2022
efb6be3
ciecle and dim 210 220 230
Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/entities/circle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ export interface ICircleEntity extends IEntity {
startAngle: number;
endAngle: number;
angleLength: number;
extrusionDirectionX: number;
extrusionDirectionY: number;
extrusionDirectionZ: number;
}

export default class Circle implements IGeometry {
Expand Down Expand Up @@ -37,6 +40,15 @@ export default class Circle implements IGeometry {
entity.angleLength = endAngle - entity.startAngle;
entity.endAngle = endAngle;
break;
case 210:
entity.extrusionDirectionX = curr.value as number;
break;
case 220:
entity.extrusionDirectionY = curr.value as number;
break;
case 230:
entity.extrusionDirectionZ = curr.value as number;
break;
default: // ignored attribute
helpers.checkCommonEntityProperties(entity, curr, scanner);
break;
Expand Down
12 changes: 12 additions & 0 deletions src/entities/dimension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ export interface IDimensionEntity extends IEntity{
actualMeasurement: number;
text: string;
angle: number;
extrusionDirectionX: number;
extrusionDirectionY: number;
extrusionDirectionZ: number;
}

export default class Dimension implements IGeometry {
Expand Down Expand Up @@ -67,6 +70,15 @@ export default class Dimension implements IGeometry {
case 50: // Angle of rotated, horizontal, or vertical dimensions
entity.angle = curr.value as number;
break;
case 210:
entity.extrusionDirectionX = curr.value as number;
break;
case 220:
entity.extrusionDirectionY = curr.value as number;
break;
case 230:
entity.extrusionDirectionZ = curr.value as number;
break;
default: // check common entity attributes
helpers.checkCommonEntityProperties(entity, curr, scanner);
break;
Expand Down
12 changes: 12 additions & 0 deletions src/entities/ellipse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ export interface IEllipseEntity extends IEntity {
startAngle: number;
endAngle: number;
name: string;
extrusionDirectionX: number;
extrusionDirectionY: number;
extrusionDirectionZ: number;
}

export default class Ellipse implements IGeometry {
Expand Down Expand Up @@ -39,6 +42,15 @@ export default class Ellipse implements IGeometry {
case 2:
entity.name = curr.value as string;
break;
case 210:
entity.extrusionDirectionX = curr.value as number;
break;
case 220:
entity.extrusionDirectionY = curr.value as number;
break;
case 230:
entity.extrusionDirectionZ = curr.value as number;
break;
default: // check common entity attributes
helpers.checkCommonEntityProperties(entity, curr, scanner);
break;
Expand Down