Fix potential vulnerability in cloned function#78
Open
navnitan-7 wants to merge 1 commit into
Open
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential vulnerability in the cloned
rebuild_proxies()implementation inlib/requests/sessions.py.Details
rebuild_proxies()lib/requests/sessions.pyChanges
Adds an HTTPS guard so
Proxy-Authorizationis not injected for HTTPS requests, preventing proxy credential leakage scenarios.Impact
Mitigates leakage of proxy credentials in redirected/tunneled request flows.
References
Made with Cursor