Address PR review: cleanup, error propagation, and remove build artifacts#4
Draft
Copilot wants to merge 2 commits into
Draft
Address PR review: cleanup, error propagation, and remove build artifacts#4Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…r propagation, IDisposable, remove App.config and build artifacts Agent-Logs-Url: https://github.com/gb63728f4/UpdateService/sessions/efd0bd1d-6f71-46ec-92a6-9920b4170156 Co-authored-by: gb63728f4 <39524431+gb63728f4@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rewrite UpdateService as WPF .NET 8
Address PR review: cleanup, error propagation, and remove build artifacts
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all review comments from the WPF .NET 8 rewrite PR. Key issues: build artifacts tracked in git,
App.configcoexisting withappsettings.json, silent copy failures allowing install to proceed on incomplete files, and minor code quality issues.Changes
OverWriteDestinationFilenow rethrows after logging soComplete/Installmodes abort if file copy fails instead of silently continuing to the install stepRegex.Match+string.ReplacewithPath.GetFileName(); removedSystem.Text.RegularExpressionsimportGetFolderNamechanged from.Where(n => n != null)!to.Where(n => !string.IsNullOrEmpty(n)).Select(n => n!), eliminating the null-forgiving suppressionJsonDocumentdisposal —LoadSettingsnow usesusing var doc = JsonDocument.Parse(json)to release pooled buffers promptlyApp.configremoved — deleted legacy .NET Framework config;appsettings.jsonis the sole config source.gitignore+ untrack build artifacts — added.gitignorecoveringbin/,obj/,.vs/,*.user; removed all previously committed build outputs from tracking