Refactored the app.py code#11
Conversation
|
Hi @saaiiravi, I have reviewed your code and that's good that you have used a functional approach but Streamlit is a very top-down approach and line-by-line execution-based API. The code here is actually breaking the application and generating some random Operations. I would recommend you to please go through the current stable code and make functions of only required features rest all can be managed in an |
| return server | ||
|
|
||
|
|
||
| def upload_cc(c1): |
There was a problem hiding this comment.
This can be easily managed in main() as c1 is a column of streamlit grid.
| c1.warning("Please select the correct column for Email Id.") | ||
|
|
||
|
|
||
| def upload_bcc(c2): |
| c2.warning("Please select the correct column for Email Id.") | ||
|
|
||
|
|
||
| def add_attachments(cc, mailid, passwrd, server): |
There was a problem hiding this comment.
no need for cc argument as all of this is handled in main()
| attachments = st.file_uploader("Attachments:", accept_multiple_files=True) | ||
|
|
||
| # Calling the core Mailer Class | ||
| mailer = Mailer(mailid, passwrd, server.lower()) |
There was a problem hiding this comment.
mailer is the core class it can be either called in the mail() or main() depending on how you structure it.
| # Calling the core Mailer Class | ||
| mailer = Mailer(mailid, passwrd, server.lower()) | ||
|
|
||
| if cc == [""]: |
There was a problem hiding this comment.
this check needs to be done in main()
| """, unsafe_allow_html=True) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
try to manage the StreamlitUI Code in main() and all logic in separate functions for better control of Streamlit UI Components.
|
hi @gauranshkumar, I've tested the code. It worked fine for me. If you can tell me what parts of the code is breaking, It'll be easier for me to do changes suggested by you and test. Also, could you give more clarity on why you're asking to move certain piece of code to main. Calling the function and putting them in the main function is ideally the same right. It didn't make sense to me. If you can explain, I will be able to understand better. |
|
Hi @saaiiravi, answering your first question, i.e where the code breaks, so actually the app runs without raising any error or warning but if you look at it carefully, as soon as we start the streamlit server the mail sending function is called automatically without pressing the sent button and it shows a notification that mail is sent successfully whereas, in reality, it isn't so it's creating a hidden bug. Also, there is an issue in rendering the subheaders as some don't render as markdown rather they are displayed as normal text. |
|
Secondly, I agree that doing everything in the |
|
I hope that makes some sense to you, so the idea here is to not just functionalize the code but rather make it less redundant and improve the quality. |
|
It makes sense. So what is the exact feature you want me to implement in a function? |
|
@gauranshkumar if you can tell me, what is the exact feature you want outside of main. I can finish It off. |
2 participants
Hi,
I've refactored it. Please review and let me know if there are any other changes to be made.