Skip to content

fix: use codex co-author trailer in /ship #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malikrohail wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix: use codex co-author trailer in /ship #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/gstack-ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ Save this summary — it goes into the PR body in Step 8.
git commit -m "$(cat <<'EOF'
chore: bump version and changelog (vX.Y.Z.W)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
EOF
)"
```
Expand Down
8 changes: 8 additions & 0 deletions scripts/gen-skill-docs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2167,6 +2167,13 @@ in the decision tree below.
If you want to persist deploy settings for future runs, suggest the user run \`/setup-deploy\`.`;
}

function generateCoauthorTrailer(ctx: TemplateContext): string {
if (ctx.host === 'codex') {
return 'Co-Authored-By: OpenAI Codex <noreply@openai.com>';
}
return 'Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>';
}

const RESOLVERS: Record<string, (ctx: TemplateContext) => string> = {
COMMAND_REFERENCE: generateCommandReference,
SNAPSHOT_FLAGS: generateSnapshotFlags,
Expand All @@ -2185,6 +2192,7 @@ const RESOLVERS: Record<string, (ctx: TemplateContext) => string> = {
TEST_FAILURE_TRIAGE: generateTestFailureTriage,
SPEC_REVIEW_LOOP: generateSpecReviewLoop,
DESIGN_SKETCH: generateDesignSketch,
COAUTHOR_TRAILER: generateCoauthorTrailer,
BENEFITS_FROM: generateBenefitsFrom,
CODEX_REVIEW_STEP: generateAdversarialStep,
ADVERSARIAL_STEP: generateAdversarialStep,
Expand Down
2 changes: 1 addition & 1 deletion ship/SKILL.md.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ Save this summary — it goes into the PR body in Step 8.
git commit -m "$(cat <<'EOF'
chore: bump version and changelog (vX.Y.Z.W)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
{{COAUTHOR_TRAILER}}
EOF
)"
```
Expand Down
10 changes: 10 additions & 0 deletions test/gen-skill-docs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,16 @@ describe('Codex generation (--host codex)', () => {
expect(content).toContain('.agents/skills/gstack');
});

test('ship co-author trailer is host-specific', () => {
const claudeShip = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md'), 'utf-8');
expect(claudeShip).toContain('Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>');
expect(claudeShip).not.toContain('Co-Authored-By: OpenAI Codex <noreply@openai.com>');

const codexShip = fs.readFileSync(path.join(AGENTS_DIR, 'gstack-ship', 'SKILL.md'), 'utf-8');
expect(codexShip).toContain('Co-Authored-By: OpenAI Codex <noreply@openai.com>');
expect(codexShip).not.toContain('Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>');
});

// ─── Path rewriting regression tests ─────────────────────────

test('sidecar paths point to .agents/skills/gstack/review/ (not gstack-review/)', () => {
Expand Down