feat: ship run log persistence for /retro velocity tracking#324
Open
jithinraj wants to merge 1 commit intogarrytan:mainfrom
Open
feat: ship run log persistence for /retro velocity tracking#324jithinraj wants to merge 1 commit intogarrytan:mainfrom
jithinraj wants to merge 1 commit intogarrytan:mainfrom
Conversation
Adds structured JSONL logging to /ship and consumption in /retro, enabling shipping velocity metrics across retrospectives. - bin/gstack-ship-log: read/write helper with --window filtering - ship Step 8.25: appends entry after PR creation (version, branch, PR URL, review findings, Greptile stats, todos completed, test coverage counts) - retro Step 2: aggregates ship velocity (runs, PRs, avg findings, Greptile catches, coverage delta) - retro Step 13: persists ship_velocity in JSON snapshot - retro Step 14: references ship log trends in narrative Also fixes pre-existing duplicate command numbering in retro Step 1 (two commands were both labeled garrytan#12).
9490fa5 to
d268b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured JSONL logging to
/shipand consumption in/retro, enabling shipping velocity metrics across retrospectives. Addresses the ship log persistence item from TODOS.md (P2 under Ship).What it does
New
bin/gstack-ship-loghelper:gstack-ship-log '{"ts":"...","version":"..."}'gstack-ship-log read(returnsNO_SHIP_LOGif empty)gstack-ship-log read --window 7d(macOS + GNU date)gstack-analytics/gstack-telemetry-logconventions (set -uo pipefail,GSTACK_STATE_DIRoverride,~/.gstack/analytics/location)Ship template (Step 8.25):
Retro template:
ship_velocityin JSON snapshot for trend trackingAdditional fix
Fixed pre-existing duplicate command numbering in retro Step 1 (two commands were both labeled
# 12).Validation
bun test: all tests pass (no regressions)bun run gen:skill-docs --dry-run: all 26 Claude skills FRESHbun run gen:skill-docs --host codex --dry-run: all 25 Codex skills FRESHbun run skill:check: all 25 skills healthy, 0 missing~/.codex/skills/gstack/bin/gstack-ship-log)gstack-ship-log(write, read, read --window, NO_SHIP_LOG)Test plan
/shipappends JSONL entry to~/.gstack/analytics/ship-log.jsonlafter PR creation/retroreads and aggregates ship log data when present/retrogracefully skips ship velocity section when no log existsbin/gstack-ship-log read --window 7dfilters entries correctly