Skip to content

Drop ABI input #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 1 commit into from
Mar 12, 2026
Merged

Drop ABI input #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ All of the following inputs are optional.
- The inputs `build-needed-pkgs`, `build-suggested-pkgs` and `build-extensions` were
added. Setting these to `true` will also compile the relevant dependencies, and setting
them to `recursive` will also compile the dependencies' dependencies, etc.
- The `ABI` input was dropped. It previously made it easy to build 32-bit versions of
packages, but we are phasing that out, so workflows should stop passing this input.

### What's new in v2

Expand Down
11 changes: 0 additions & 11 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: 'Compile GAP package'
description: 'Compile the given GAP package being tested'
inputs:
ABI:
description: 'set to 32 to use 32bit build flags for the package'
required: false
default: ''
coverage:
description: 'Boolean that determines whether code coverage is turned by adding `--coverage` to `CFLAGS`, `CXXFLAGS` and `LDFLAGS`.'
required: false
Expand Down Expand Up @@ -72,13 +68,6 @@ runs:
export LDFLAGS="$LDFLAGS --coverage"
fi

# adjust build flags for 32bit builds
if [[ "${{ inputs.ABI }}" = 32 ]]; then
export CFLAGS="$CFLAGS -m32"
export CXXFLAGS="$CXXFLAGS -m32"
export LDFLAGS="$LDFLAGS -m32"
fi

# build this package, if necessary
if [[ -x prerequisites.sh ]]; then
./prerequisites.sh $GAPROOT
Expand Down