Skip to content

build: silence pnpm 10 'ignored build scripts: esbuild' warning#5

Merged
gamween merged 1 commit into
mainfrom
fix/pnpm-approve-esbuild-build
Jun 16, 2026
Merged

build: silence pnpm 10 'ignored build scripts: esbuild' warning#5
gamween merged 1 commit into
mainfrom
fix/pnpm-approve-esbuild-build

Conversation

@gamween

@gamween gamween commented Jun 16, 2026

Copy link
Copy Markdown
Owner

What

Every pnpm install logged a warning (visible in the Vercel build log and watcher's CI log):

Warning: Ignored build scripts: esbuild@…
Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts.

Why it happened (and why it was benign)

pnpm 10 stopped running dependencies' build scripts unless explicitly approved. esbuild has a postinstall (install.js), so it got flagged. The builds still succeeded because esbuild's actual binary ships via its @esbuild/<platform> optional dependency, not the postinstall — so the script being skipped was harmless. Hence: a warning, never an error.

Fix

Approve esbuild's build script via pnpm.onlyBuiltDependencies in each standalone project (site, watcher, video — there's no workspace, each has its own lockfile). Approval is by package name, so it covers every pinned esbuild version (watcher has 0.21.5 + 0.28.1).

Verification

  • pnpm install in all three → no ignored-scripts warning (esbuild postinstall now runs)
  • Lockfiles unchanged
  • site build green · watcher tests green (25/25)

After merge, the Vercel production build for main will be 0 errors, 0 warnings.

…warning)

pnpm 10 no longer runs dependencies' build scripts unless explicitly approved,
so every install logged:
  Warning: Ignored build scripts: esbuild@...
The builds still succeed (esbuild's binary ships via its @esbuild/<platform>
optional dependency, not the postinstall), so this was a benign warning — but it
dirtied the Vercel build log (and watcher's CI log).

Approve esbuild via pnpm.onlyBuiltDependencies in each standalone project
(site, watcher, video — no workspace, separate lockfiles). Approval is by
package name, covering all pinned esbuild versions. Lockfiles unchanged.

Verified: pnpm install in all three → no ignored-scripts warning; site build +
watcher tests (25) green.
Copilot AI review requested due to automatic review settings June 16, 2026 22:54
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
coincoin Ready Ready Preview, Comment Jun 16, 2026 10:54pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gamween gamween merged commit fb944d7 into main Jun 16, 2026
5 checks passed
@gamween gamween deleted the fix/pnpm-approve-esbuild-build branch June 16, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants