Skip to content

A few changes necessary to run a realistic model of the south illuminators#2092

Draft
orelgueta wants to merge 5 commits intomainfrom
illuminator_south
Draft

A few changes necessary to run a realistic model of the south illuminators#2092
orelgueta wants to merge 5 commits intomainfrom
illuminator_south

Conversation

@orelgueta
Copy link
Contributor

Two changes implemented here,

  • The schema validation failed when I tried setting
    flasher_pulse_shape:
          version: "2.0.0"
          value: ["Gauss-Exponential", 0.1699, 1.8398]
          unit: [null, ns, ns]
          model_parameter_schema_version: "0.2.0"
    
    even though the code should support this. Either way, I don't think so many changes are actually necessary to get it to work. I will try reducing them before making this a real PR.
  • The Gauss-Exponential was only supported for the flasher, not for illuminators. That I modified in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant