Open
Conversation
|
GernotMaier
requested changes
Mar 27, 2026
Contributor
GernotMaier
left a comment
There was a problem hiding this comment.
You want to fix the SonarQ and Copilot comments?
Comment on lines
+43
to
+46
| return False | ||
| parts = tuple(path.parts) | ||
| db_parts = ("tests", "unit_tests", "db") | ||
| return any(parts[idx : idx + 3] == db_parts for idx in range(max(len(parts) - 2, 0))) |
There was a problem hiding this comment.
pytest_collection_modifyitems relies on item.path, but the rest of this conftest (and older pytest versions) use request.node.fspath. If item.path isn’t present (e.g., pytest versions that only expose fspath), db tests won’t be auto-marked and fixture routing can regress. Consider falling back to item.fspath (convert to Path(str(...))) when item.path is missing.
Suggested change
| return False | |
| parts = tuple(path.parts) | |
| db_parts = ("tests", "unit_tests", "db") | |
| return any(parts[idx : idx + 3] == db_parts for idx in range(max(len(parts) - 2, 0))) | |
| fspath = getattr(item, "fspath", None) | |
| if fspath is None: | |
| return False | |
| path = Path(str(fspath)) | |
| parts = tuple(path.parts) | |
| db_parts = ("tests", "unit_tests", "db") | |
| return any( | |
| parts[idx : idx + 3] == db_parts for idx in range(max(len(parts) - 2, 0)) | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.