Add decliniation line support in production grid#2075
Open
tobiaskleiner wants to merge 22 commits intomainfrom
Open
Add decliniation line support in production grid#2075tobiaskleiner wants to merge 22 commits intomainfrom
tobiaskleiner wants to merge 22 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RA/Dec declination-line support to production grid generation and introduces a new plotting utility to visualize production-grid points in both local Alt/Az and equatorial RA/Dec projections.
Changes:
- Extend
GridGenerationto supportcoordinate_system="ra_dec"with (a) native declination-line/hour-angle sampling and (b) explicit RA/Dec axes mode. - Add
ProductionGridPlotterplus new CLI entrypointsimtools-plot-production-grid, including docs and integration configs. - Add/extend unit tests and test resources for RA/Dec grid generation and production-grid plotting.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/simtools/production_configuration/generate_production_grid.py |
Adds RA/Dec grid generation modes and lookup-table interpolation path for RA/Dec workflows. |
src/simtools/production_configuration/plot_production_grid.py |
New plotting module for production-grid sky projections with optional RA/Dec guide tracks. |
src/simtools/applications/plot_production_grid.py |
New CLI application wiring site metadata + plotter invocation. |
src/simtools/applications/production_generate_grid.py |
Updates CLI docs/help to describe new RA/Dec behavior. |
tests/unit_tests/production_configuration/test_generate_production_grid.py |
Adds RA/Dec-mode unit tests and refactors GridGeneration setup in tests. |
tests/unit_tests/production_configuration/test_plot_production_grid.py |
New unit tests covering normalization, inferred tracks, and output generation. |
tests/resources/production_grid_generation_axes_definition_radec.yml |
New RA/Dec axes definition fixture for tests/integration. |
tests/integration_tests/config/production_generate_grid_radec.yml |
New integration workflow for RA/Dec grid generation. |
tests/integration_tests/config/plot_production_grid.yml |
New integration workflow for plotting production grids. |
docs/source/user-guide/applications/simtools-plot-production-grid.rst |
New user-guide stub for the plotting CLI. |
docs/source/user-guide/applications.md |
Adds the new plotting CLI to the applications list. |
docs/source/api-reference/production_configuration.md |
Adds API docs entry for production_configuration.plot_production_grid. |
pyproject.toml |
Registers simtools-plot-production-grid console script. |
src/simtools/production_configuration/generate_production_grid.py
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RA/Dec declination-line support to production grid generation and introduces a new plotting utility to visualize production-grid points in both local Alt/Az and equatorial RA/Dec projections.